Hi, I'm new to the forum and I have just recently decided to begin to learn the Major scale, I've been practicing playing the G major scale for about a week, what I've been doing is playing all the notes and saying them aloud in my head before playing each one, planning hopefully that eventually I will memorize where all the notes are, so I will be able to switch to the other major scales easily since I will already know where the notes are, but I want to make sure I'm not wasting my time practicing this over and over again, because basically all I have been doing for the past week is playing the scale for 2 hours a day, but I want to make sure I'm not practicing incorreclty, because I really want to dedicate myself to be able to make up solos, and melodies and improv over chord changes, I know i can put the time in but I'm just not quite sure where to start. Does it sound like I'm practicing correctly?, and if anyone can give me some advice on other things to practice as well that would be greatly appreciated, because it gets boring playing the same scale over and over again. Also how long did it take for you guys to really get to know all the notes, because it takes me a while to remember where the notes are on the fretboard when I play them.
Thanks a lot!(hopefully this was clear)